[BPF] rework L2 overlay (vxlan) for performance #9965
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tomastigera
force-pushed
the
tomas-bpf-vxlan-perf-fix
branch
2 times, most recently
from
9945acc to
b929a89
Compare
tomastigera
added
docs-not-required
tomastigera
force-pushed
the
tomas-bpf-vxlan-perf-fix
branch
2 times, most recently
from
a3fa044 to
8e90865
Compare
It is sometimes handy to set explicitly what MTU should be used on a certain route, for instance when a tunnel device is used for both ipv4/6 and the MTU is different each.
This is a stepping stone for ebpf to move to a single vxlan device for both v4/6. We do not want to set MTU on the device, but host networked processes will need to know what the MTU should be.
IT is a historical artefact and we should name it properly and leave the name tunnel for a generic overlay.
We need to know that we are forwarding from and L2 overlay.
This allows us to use bpf_skb_set_tunnel_key for fast forwarding via the vxlan overlay.
Also redirect from a pod to a local pod with bpf_redirect_peer when possible.
Tunnel key is set at the vxlan device as that the the first place where to set it.
We needed to propagate it to the bpf programs as it is no longer set on the vxlan device itself.
The way the vxlan device is setup now makes having two device unnecessary. In fact, two devices would not work well as they may get packet meant for the other one. It does not really break things, but it is a mess.
tomastigera
force-pushed
the
tomas-bpf-vxlan-perf-fix
branch
from
8e90865 to
548244b
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.